-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Source directory option for tests #191
base: devel
Are you sure you want to change the base?
Conversation
…g on Python < 3.8 and Python >=3.8
Closes #190 |
Documentation has been updated to reflect the new directory, and I have added a new environment variable to allow referencing to the source directory. |
I can confirm that sym-links also work!! This worked when I tried it:
This makes it much easier to maintain differences if needed by more than 1 test. |
I'm finding some sort of problem with the old-Python implementation of this:
If I load a newer Python version, then it works as expected. Working to reproduce now. |
The sym-links that I previously reported as working appear to no longer be working 🤔 . It's possible that I only checked the sym-links for the newer Python version and that I didn't actually verify it for the shell implementation. |
Okay, so the problem was that I had sym-links going to & from multiple test source directories. For example, maintain a
The I've pushed these changes to the default behavior now, and confirmed that it is working for my newly-refactored |
Added the ability to have a Source directory under each test.
This directory is copied second and will override any files in the main Source directory.
This is currently implemented with a conditional to allow for Python < 3.8 to still run, with the intention to remove that conditional once all OLCF machines use Python >3.8 in the coming years.