Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

datho7561
Copy link
Contributor

Closes #165

Signed-off-by: David Thompson [email protected]

Closes oldterns#165

Signed-off-by: David Thompson <[email protected]>
@datho7561
Copy link
Contributor Author

@Kevin-Mok pipeline appears to be working (see https://github.com/datho7561/VileBot/actions?query=branch%3A165-github-actions), but there is a test failure. Do you think I should look into fixing that failure in this PR?

@Kevin-Mok
Copy link

@datho7561 We can open a new issue for it. Do you know if this will run the tests for @Christopher-Chianelli's #161 PR?

@Christopher-Chianelli
Copy link
Contributor

Reading it, as of now, no; but I know what modifications to make to make it work on my PR

@Christopher-Chianelli
Copy link
Contributor

In regards to the test failure, it appears to be a BOM (Byte Order Mark) issue that present in the news feed RSS (It also why !news isn't working; it was introduced one day and was never removed). These are bad tests; they depend on the internet; I have a solution for test of these services in my PR.

@datho7561
Copy link
Contributor Author

#167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate CI
3 participants