New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Today shouldn't equal now #13

Open

orius123 opened this issue Jan 17, 2019 · 1 comment

orius123 commented Jan 17, 2019

Thanks for this great library!

There is an empty impl at today rule.

when/rules/en/casual_date.go

Line 27 in 53693fb

// c.Hour = pointer.ToInt(18)

IMHO it should equal start of day

dmitshur commented Jan 20, 2019

It looks like PR #14 is related to this issue.

dmitshur mentioned this issue

Make today/tomorrow/yesterday at the beginning of the day #14

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment