Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: Selector can not specify both 'start' and 'end' key when specifying 'prefix'" when use getMany #251

Closed
Xu-pixel opened this issue Dec 19, 2024 · 4 comments

Comments

@Xu-pixel
Copy link
Contributor

Xu-pixel commented Dec 19, 2024

enviroment: bun 1.1.38 macos 15
i find that it cause by handlemany->createSelector
because denokv will check selector and forbidden use start ,end, prefix at the same time even if undefined
https://github.com/denoland/denokv/blob/a9eb782be66477b32e96a692c8c34f807ad10bcd/npm/src/kv_util.ts#L115
image

@Xu-pixel
Copy link
Contributor Author

image
image

@oliver-oloughlin
Copy link
Owner

Weird quirk, but nicely done figuring it out! The change you made makes sense to me, if you care to make a PR I will gladly accept it :)

@Xu-pixel
Copy link
Contributor Author

yes,i make a pr (#252 change the fn createListSelector) and test in deno(i don't how to test in bun) although i think this is a problem with denokv, i can avoid it by modifying kvdex.
If you could merge this PR, I would be very grateful.

@oliver-oloughlin
Copy link
Owner

Closing this now as your fix has been merged and released as of 3.0.2. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants