This repository has been archived by the owner on Feb 23, 2021. It is now read-only.

Unintentional mutations #96

Open

Jwhiles opened this issue May 11, 2017 · 0 comments

Jwhiles commented May 11, 2017 •

edited

Loading

This line bookInfo = bookInfo.sort((a, b) => is dangerous.

calling .sort on an array mutates the original array. This means that reassigning bookInfo to a sorted version of itself is a redundant.

More importantly this could cause very weird and hard to track down bugs if you later expand this piece of code.

The text was updated successfully, but these errors were encountered:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.