From 5192f310015a16310b25f3225be61c679672df4e Mon Sep 17 00:00:00 2001 From: Tom Rossi Date: Fri, 24 May 2024 14:50:08 +0000 Subject: [PATCH] Mark `preview_image_needed_before_processing_variants?` as private API It looks like `preview_image_needed_before_processing_variants?` was added recently, but it's stated as being public API. However, it looks like it's more of an implementation detail that's not meant for Active Storage users. So this marks it as nodoc, so we're not on the hook for maintaining it. --- activestorage/app/models/active_storage/blob/representable.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/activestorage/app/models/active_storage/blob/representable.rb b/activestorage/app/models/active_storage/blob/representable.rb index 5d71eaeeccf47..99cd72fc5cf0d 100644 --- a/activestorage/app/models/active_storage/blob/representable.rb +++ b/activestorage/app/models/active_storage/blob/representable.rb @@ -98,7 +98,7 @@ def representable? variable? || previewable? end - def preview_image_needed_before_processing_variants? + def preview_image_needed_before_processing_variants? # :nodoc: previewable? && !preview_image.attached? end