Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: PDF Error #210

Closed
1 task done
Withered-Flower-0422 opened this issue Mar 23, 2024 · 5 comments
Closed
1 task done

[Bug]: PDF Error #210

Withered-Flower-0422 opened this issue Mar 23, 2024 · 5 comments
Assignees
Labels

Comments

@Withered-Flower-0422
Copy link

Withered-Flower-0422 commented Mar 23, 2024

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

OpenComic Version

1.1.0

Operating System

win11 23h2

Steps to reproduce

  1. Drag a pdf into the window.
  2. An error occurred.
  3. Each time I click on the Library and Recents, the error occurs, and I can't delete them.

Expected Behavior

When a pdf is dragged into the window, give a hint that "The file is not supported".
Or if pdfs are supported, make it work correctly, instead of repeating showing the error.

Actual Behavior

I mistakenly dragged a pdf into the window, then an error occurred.
image
After that, each time I click on the Library and Recents, the error occurs, and I can't delete them.

Error message

No response

Additional Information

No response

Sample file

No response

@Withered-Flower-0422
Copy link
Author

I've tried the setup version and the portable version.
The setup one has the bug, while the portable one handles pdfs well.

@ollm ollm self-assigned this Mar 24, 2024
@ollm
Copy link
Owner

ollm commented Mar 24, 2024

OpenComic supports PDF files.

Can you send me the PDF file that is causing the error? [email protected]
Can you also show me the complete error in the console? Debbug > Toogle DevTools

As a temporary fix, you can rename or move the PDF file that is giving the error in the file explorer, so that OpenComic does not try to open it.

@Withered-Flower-0422
Copy link
Author

Withered-Flower-0422 commented Mar 24, 2024

After my debugging, I think I find the problem.
My folder name contains a #, which causes this bug.

Not pdf files' fault, sorry for the misguiding.

@ollm
Copy link
Owner

ollm commented Mar 24, 2024

From what I've seen, it's a pdf.js bug mozilla/pdf.js#10632

At the moment I have updated pdf.js to the latest version and made some corrections to solves the problem with the # (5691073 and 4fda215)

This is the build with the fix https://mega.nz/file/3bhyQD5Y#KwmcChEdpy92FUQF2V5MksW6tERzTrsNQHeveLL0FGQ

@ollm
Copy link
Owner

ollm commented Mar 29, 2024

Closed as fix available in v1.2.0

@ollm ollm closed this as completed Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants