Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Image Transitions #225

Closed
1 task done
Laughingcow opened this issue Apr 29, 2024 · 7 comments
Closed
1 task done

[Feature Request]: Image Transitions #225

Laughingcow opened this issue Apr 29, 2024 · 7 comments
Assignees

Comments

@Laughingcow
Copy link

Preflight Checklist

  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe your suggested feature

Is it possible to add image transitions such as page turn and fades? I want to have a proper feel of reading a comic book and having that effect makes a difference. GonVisor has a whole slew of these but is temperamental and doesn't read all file formats.

Another bit is having a SoundFX play during the transition. Honeyview had this before it was removed where a page turning sound would play everytime a page was turned.

Additional Information

No response

Sample file

No response

@ollm ollm self-assigned this Apr 30, 2024
@ollm
Copy link
Owner

ollm commented Apr 30, 2024

I'll see if it's possible to do, the fading effect is easy, but the transitions that simulates a page turn may be more complicated.

@Laughingcow
Copy link
Author

It isn't just the effect itself but the speed on which is goes. Gonvisor has the ability to set the speed on which the transition goes. I have no idea how this works from a technical perspective but it is possible. I highly recommend looking into GonVisor and how it handles all this.
Screenshot 2024-04-30 085253
Screenshot 2024-04-30 085258
Screenshot 2024-04-30 085207

Could help you figure things out.

@ollm
Copy link
Owner

ollm commented Apr 30, 2024

I've looked at it a bit to see how the animation works, and the one it uses is not very complicated, although I would like to try to make it look more like a real page, so I will continue investigating if it is possible to do so.

Regarding speed, you can currently adjust in OpenComic.

Captura desde 2024-04-30 18-58-29

@Laughingcow
Copy link
Author

Good to know.

If you can get it to work, the next thing would be getting sounds for the transitions. There's plenty of sounds on youtube and other places.
https://www.youtube.com/watch?v=tAADqtTtT7k

The idea is that during the page transition, you can have it play a small sound cue if you wanted. Again, it helps with the immersion.

@ollm
Copy link
Owner

ollm commented May 3, 2024

I will also take it into account for this feature, if there is any other type of sound that you would like there to be when turning the page, you can also send me an example video/audio.

@Laughingcow
Copy link
Author

Nothing comes to mind but I imagine others might think otherwise. I think a better solution than adding a bunch of sounds is to allow users add custom sounds if they want. That would save you a headache in the long run.

@ollm
Copy link
Owner

ollm commented Oct 4, 2024

Hi @Laughingcow

I have implemented 2 page turn effects in the new OpenComic version (v1.3.0), with also multiples sound effects, the custom sound effects are not yet implemented, but I have opened a new issue about it #276

  • Page turn transitions and fade 3592392
  • Sound effect on page turn d9957da

Here are some example videos, both transitions still have some bugs in certain conditions, but I plan to fix it in nexts versions.

#276

Page turn

2024-10-04.17-23-47.mp4

Smooth page turn

2024-10-04.17-27-56.mp4

Page turn with high perspective

2024-10-04.17-29-22.mp4

Page turn with low perspective

2024-10-04.17-29-35.mp4

@ollm ollm closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants