Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from using react tools to esprima-fb parser #6

Open
mikesherov opened this issue Nov 27, 2014 · 1 comment
Open

Switch from using react tools to esprima-fb parser #6

mikesherov opened this issue Nov 27, 2014 · 1 comment

Comments

@mikesherov
Copy link

JSCS 1.8 is out now with the ability to specify a variant of esprima. FB maintains esprima-fb which parses jsx files. This package should be basically equivalent now to gulp-jscs except automatically specifying the esprima-fb as the parser.

@agschwender
Copy link
Contributor

Thanks for reaching out and sorry for not replying sooner. Just switched it over to use esprima-fb instead of react-tools in 620def3. All the tests pass except for the test that handles flow types. The module is using react-tools to strip them out before parsing. Did a quick search and didn't see anything promising for achieving that without react-tools, but I'm certainly no expert. Do you have any recommendations for having jscs ignore these? If not, no worries; they should probably be getting stripped upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants