Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate changebar document #3

Open
barmac opened this issue Jul 5, 2023 · 10 comments
Open

Generate changebar document #3

barmac opened this issue Jul 5, 2023 · 10 comments

Comments

@barmac
Copy link
Contributor

barmac commented Jul 5, 2023

Generate changebar document

@barmac
Copy link
Contributor Author

barmac commented Jul 10, 2023

Tool candidate: https://github.com/davidar/pandiff

@barmac
Copy link
Contributor Author

barmac commented Jul 10, 2023

  1. I pandiff both files and produce PDF
  2. The PDF is ready to view.

@barmac
Copy link
Contributor Author

barmac commented Jul 10, 2023

I run into a problem with pandoc which should be solvable:

❯ npx pandiff -s origin.adoc 10-expression-language-FEEL.adoc -o diff.pdf
Unknown input format asciidoc
Error: 21

@barmac
Copy link
Contributor Author

barmac commented Jul 10, 2023

At https://pandoc.org/, it says that asciidoc is only a target format for the tool. That could explain why it doesn't work. Let's dig more.

@barmac
Copy link
Contributor Author

barmac commented Jul 10, 2023

More on above: jgm/pandoc#1456 Still not implemented.

@barmac
Copy link
Contributor Author

barmac commented Jul 10, 2023

I am trying out a three-step flow:

graph TD;
    asciidoc-->html;
    html-->pdf;
Loading

@barmac
Copy link
Contributor Author

barmac commented Jul 10, 2023

For some reason the pandiff command failed:

❯ npx pandiff origin.html 10-expression-language-FEEL.html -o diff.pdf
Error producing PDF.
! LaTeX Error: File `soul.sty' not found.

Type X to quit or <RETURN> to proceed,
or enter new name. (Default extension: sty)

Enter file name:
! Emergency stop.
<read *>

l.45 \fi

Error: 43

Gotta look into this later.

@barmac
Copy link
Contributor Author

barmac commented Jul 10, 2023

Commands I tried:

brew install basictex # required for pandiff on MacOS
asciidoctor origin.adoc 10-expression-language-FEEL.adoc
npx pandiff origin.html 10-expression-language-FEEL.html -o diff.pdf

@barmac
Copy link
Contributor Author

barmac commented Jul 10, 2023

Output of this command looks terrible:

npx pandiff origin.html 10-expression-language-FEEL.html -o diff.html

File needs to be renamed to diff.html:

diff.html.txt

@falko
Copy link
Contributor

falko commented Jul 10, 2023

Yes, just strike-through and underline is not very pretty. Also we would need to annotate, by which issue/PR a change has been made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants