Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to tensorflow 2.3.0 and refactor #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Port to tensorflow 2.3.0 and refactor #5

wants to merge 2 commits into from

Conversation

elazarg
Copy link

@elazarg elazarg commented Aug 5, 2020 •
edited
Loading

Main changes:

  • Refactor and simplify architecture code
    • Refactor common architecture code to dedicated functions
    • Refactor experiment code to a single function
    • Add titles to to the plots
  • Don't use keras directly; use tensorflow instead (keras is not independent of tensorflow anymore).
    • No need to cleanup sessions, so keras.backend is not needed.
  • Create directory when it does not exist (Fix enable smooth reproduction #4)

The functions for word and for char are not always exactly the same. I wonder if that's intentional.

The code for BiLSTM crashes on my machine, so there are no plots there, but this has nothing to do with this PR.

(This PR probably works with 2.2 too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable smooth reproduction
1 participant
@elazarg