From 41b7c87f61ae552435fd98230360dc7d322645b9 Mon Sep 17 00:00:00 2001 From: Luca8991 Date: Wed, 29 Nov 2023 22:33:27 +0100 Subject: [PATCH 1/3] feat: increase default ack message timeout --- src/ic-websocket.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ic-websocket.ts b/src/ic-websocket.ts index f3c1191..e48d966 100644 --- a/src/ic-websocket.ts +++ b/src/ic-websocket.ts @@ -39,7 +39,7 @@ import { WsAgent } from "./agent"; * The default expiration time for receiving an ack message from the canister after sending a message. * It's **3/2 times** the canister's default send ack period. */ -const DEFAULT_ACK_MESSAGE_TIMEOUT_MS = 90000; +const DEFAULT_ACK_MESSAGE_TIMEOUT_MS = 450_000; /** * Interface to create a new IcWebSocketConfig. For a simple configuration, use {@link createWsConfig}. @@ -65,7 +65,7 @@ export interface IcWebSocketConfig { * The expiration (in milliseconds) time for receiving an ack message from the canister after sending a message. * If the ack message is not received within this time, the connection will be closed. * This parameter should always me **3/2 times or more** the canister's send ack period. - * @default 90000 (90 seconds = 3/2 default send ack period on the canister) + * @default 450_000 (7.5 minutes = 3/2 default send ack period on the canister) */ ackMessageTimeout?: number; /** From afb31b1064433418f234c3f5a6a3f9d53e363558 Mon Sep 17 00:00:00 2001 From: Luca8991 Date: Wed, 29 Nov 2023 22:36:59 +0100 Subject: [PATCH 2/3] chore: disable tests on draft PRs --- .github/workflows/tests.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index d6e16d3..a2aab2b 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -6,9 +6,15 @@ on: branches: - main pull_request: + types: + - opened + - synchronize + - reopened + - ready_for_review jobs: tests: + if: github.event.pull_request.draft == false runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From 2addcf7e774850b902318b598bdf1174c67a5ca1 Mon Sep 17 00:00:00 2001 From: Luca8991 Date: Mon, 4 Dec 2023 12:51:17 +0100 Subject: [PATCH 3/3] chore: bump to version v0.3.1 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index e7fb5dc..894c104 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "ic-websocket-js", - "version": "0.3.0", + "version": "0.3.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "ic-websocket-js", - "version": "0.3.0", + "version": "0.3.1", "license": "MIT", "dependencies": { "loglevel": "^1.8.1" diff --git a/package.json b/package.json index b9c0646..f0266c6 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "ic-websocket-js", - "version": "0.3.0", + "version": "0.3.1", "description": "IC WebSocket on the Internet Computer", "license": "MIT", "repository": {