Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate between invalid binding credentials and invalid login credentials #51

Open
mtalcott opened this issue Nov 6, 2014 · 0 comments · May be fixed by #52
Open

Differentiate between invalid binding credentials and invalid login credentials #51

mtalcott opened this issue Nov 6, 2014 · 0 comments · May be fixed by #52

Comments

@mtalcott
Copy link

mtalcott commented Nov 6, 2014

Currently, providing a bad username or password in the configuration and a user submitting invalid credentials both redirect to auth/failure with invalid_credentials as the failure message. There is no way to distinguish between the two cases.

Other LDAP connection errors cause the failure message ldap_error, which makes more sense if there is a problem with the configuration.
mtalcott pushed a commit to mtalcott/omniauth-ldap that referenced this issue Nov 6, 2014
Make LDAP bind failure cause an ldap_error, rather than an invalid_cr…
4095703 
…edentials

Fixes omniauth#51
@mtalcott mtalcott linked a pull request Nov 6, 2014 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mtalcott