Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve highlight colors in Obsidian #166

Open
firmart opened this issue Dec 11, 2023 · 5 comments
Open

Preserve highlight colors in Obsidian #166

firmart opened this issue Dec 11, 2023 · 5 comments

Comments

@firmart
Copy link

firmart commented Dec 11, 2023

Currently, Omnivore offers 4 kinds of color to highlight segments of text. However, the highlight color in the converted Obsidian file is always yellow, no matter the chosen color in Omnivore. This might be annoying if each color has been assigned different meanings.

@firmart firmart changed the title Keep highlight colors in Obsidian Preserve highlight colors in Obsidian Dec 11, 2023
@aaachen
Copy link
Contributor

aaachen commented Jan 8, 2024

Encountered same in my workflow, will work on putting out a change

@Lorite
Copy link

Lorite commented Mar 17, 2024

Hi, have you found a solution? @aaachen
I'm using https://github.com/chetachiezikeuzor/Highlightr-Plugin and it would be amazing if they would work together.

@aaachen
Copy link
Contributor

aaachen commented Mar 23, 2024

Hi, sorry for the delay, been postponing on this for other stuff

Yes the ability to integrate with highlightr plugin is part of my plan for impl, I'll look more into omnivore APIs n get back

Update - 3/27:
Mapped out how to do it, working on impl

@aaachen
Copy link
Contributor

aaachen commented Apr 10, 2024

PR out:
#215

@Lorite
Copy link

Lorite commented May 27, 2024

PR out:
#215

Hi @aaachen, thanks for your amazing work.

I think there's a bug when selecting "Render Highlight Color" and "Use Highlightr for Highlight styling" and following this guide https://blog.omnivore.app/p/guide-for-syncing-highlight-colors. I see the individual highlights in their blocks fine, but for the highlights inside the {{content}} they use double equals (==like this==), not the css classes. Is that intended behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants