Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys as file path - why? #53

Open
jspetrak opened this issue Apr 6, 2023 · 2 comments
Open

Keys as file path - why? #53

jspetrak opened this issue Apr 6, 2023 · 2 comments

Comments

@jspetrak
Copy link

jspetrak commented Apr 6, 2023

Hello,
Is there a reason why the keys must be provided as file paths? We are obtaining the keys from AWS S3 so I now workaround using tmp file but would like to provide a PR to be able to provide the key values directly.

@ondrakoupil
Copy link
Owner

Hi, I think there is no reason for that, it was just the most common way how the key was saved. If you make a PR that enables both ways to provide the key, that will be great.

@jspetrak
Copy link
Author

@ondrakoupil Thanks for the reaction. I have proposed the change in pr #54. Feel free to comment if you like that or prefer different approach. It is also a BC, but that could be resolved by the union type string|KeyProvider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants