Host Implementation of Histogram APIs #1974
Open
+257
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
This reverts commit 8d61609.
This reverts commit 6f0a9cb.
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
danhoeflinger
changed the title
danhoeflinger
requested review from
reble,
timmiesmith,
akukanov,
MikeDvorskiy,
SergeyKopienko,
mmichel11,
adamfidel and
dmitriy-sobolev
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
mmichel11
reviewed
Jan 3, 2025
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
mmichel11
reviewed
Jan 7, 2025
| __construct_by_args(_P&&... __args) : __pack(std::forward<_P>(__args)...) {} | ||
|
|
||
| private: | ||
| std::tuple<_P...> __pack; |
There was a problem hiding this comment.
Should we include <tuple> in this header?
| std::unique_ptr<_StorageType> | ||
| construct() override | ||
| { | ||
| return std::move( |
There was a problem hiding this comment.
Is there a reason std::move is needed here?
Comment on lines
+211
to
+218
| for (; __j < __thread_specific_storage.size() && __count <= __i; ++__j) | ||
| { | ||
| // Only include storage from threads which have instantiated a storage object | ||
| if (__thread_specific_storage[__j]) | ||
| { | ||
| __count++; | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we expect in the general case that each thread constructs its own container? If so, would it be possible to add a check like the following before this? :
if (size() == __thread_specific_storage.size())
return *__thread_specific_storage[__i];
If I understand correctly, each thread constructing its local storage would mean the ith id would be at index i. For a CPU with a large number of threads this may be more performant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of histogram APIs for host backends.
Implementations are provided for
serial,tbb, andopenMPbackends. We add a generic__thread_enumerable_storagestruct to add a generic thread local storage for our host backends. We use the new TLS (Thread local storage) withparallel_forto implement histogram. Testing is also added, and some minor adjustments are made to cmake.Please see the RFC documentation / discussion here for more details.