Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure GetInfo CTS tests to use separate tests instead of a switch #2290

Open
4 of 13 tasks
martygrant opened this issue Nov 6, 2024 · 0 comments
Open
4 of 13 tasks

Restructure GetInfo CTS tests to use separate tests instead of a switch #2290

martygrant opened this issue Nov 6, 2024 · 0 comments
Labels
conformance Conformance test suite issues.

Comments

@martygrant
Copy link
Contributor

martygrant commented Nov 6, 2024 •
edited
Loading

As per #2272 (comment) most of the GetInfo CTS tests use a switch statement to test all of the possible info type enumerations (e.g. https://github.com/oneapi-src/unified-runtime/blob/main/test/conformance/context/urContextGetInfo.cpp#L43). It may be better that these are modified to be separate and individual tests.
@martygrant martygrant added the conformance Conformance test suite issues. label Nov 6, 2024
@martygrant martygrant mentioned this issue Nov 6, 2024
Merged
@isaacault isaacault mentioned this issue Dec 6, 2024
Closed
isaacault added a commit to isaacault/unified-runtime that referenced this issue Dec 10, 2024
@isaacault
Align Kernel CTS and Specification.
1f0e326 
* Separate parameterized tests. Progresses oneapi-src#2290.
* urKernelGetGroupInfo CompileWorkGroupSize test modified to use distinct
  dimensions.
* urKernelSetArgPointer no longer returns invalid argument size.
* Testcases added:
    * urKernelGetGroupInfo CompileMaxWorkGroupSize
    * urKernelGetGroupInfo CompileMaxLinearWorkGroupSize
    * urKernelGetSubGroupInfo CompileNumSubGroups
    * urKernelRetain CheckReferenceCount
    * urKernelRelease CheckReferenceCount
    * urKernelSetArgMemObj InvalidEnumeration
@isaacault isaacault mentioned this issue Dec 10, 2024
Open
martygrant added a commit to martygrant/unified-runtime that referenced this issue Dec 12, 2024
@martygrant
Improvements to align CTS and Spec for Device:
00d3b91 
- Rework urDeviceGetInfoTest to move all enums to their own tests instead of a switch case (oneapi-src#2290)
- Remove the UR/OpenCL enum map function - no point maintaining both a switch case and a separate mapping function
- Update some spec wording for consistency
- Add missing info enums to OpenCL adapater
- Add new urDevicePartition test for checking UR_DEVICE_INFO_PARENT_DEVICE
isaacault added a commit to isaacault/unified-runtime that referenced this issue Dec 13, 2024
@isaacault
Align Kernel CTS and Specification.
4bd7a56 
* Separate parameterized tests. Progresses oneapi-src#2290.
* urKernelGetGroupInfo CompileWorkGroupSize test modified to use distinct
  dimensions.
* urKernelSetArgPointer no longer returns invalid argument size.
* Testcases added:
    * urKernelGetGroupInfo CompileMaxWorkGroupSize
    * urKernelGetGroupInfo CompileMaxLinearWorkGroupSize
    * urKernelGetSubGroupInfo CompileNumSubGroups
    * urKernelRetain CheckReferenceCount
    * urKernelRelease CheckReferenceCount
    * urKernelSetArgMemObj InvalidEnumeration
isaacault added a commit to isaacault/unified-runtime that referenced this issue Dec 16, 2024
@isaacault
Align Kernel CTS and Specification.
e048b8e 
* Separate parameterized tests. Progresses oneapi-src#2290.
* urKernelGetGroupInfo CompileWorkGroupSize test modified to use distinct
  dimensions.
* urKernelSetArgPointer no longer returns invalid argument size.
* Testcases added:
    * urKernelGetGroupInfo CompileMaxWorkGroupSize
    * urKernelGetGroupInfo CompileMaxLinearWorkGroupSize
    * urKernelGetSubGroupInfo CompileNumSubGroups
    * urKernelRetain CheckReferenceCount
    * urKernelRelease CheckReferenceCount
    * urKernelSetArgMemObj InvalidEnumeration
martygrant added a commit to martygrant/unified-runtime that referenced this issue Dec 18, 2024
@martygrant
Improvements to align CTS and Spec for Device:
40ff6d5 
- Rework urDeviceGetInfoTest to move all enums to their own tests instead of a switch case (oneapi-src#2290)
- Remove the UR/OpenCL enum map function - no point maintaining both a switch case and a separate mapping function
- Update some spec wording for consistency
- Add missing info enums to OpenCL adapater
- Add new urDevicePartition test for checking UR_DEVICE_INFO_PARENT_DEVICE
martygrant added a commit to martygrant/unified-runtime that referenced this issue Dec 18, 2024
@martygrant
Improvements to align CTS and Spec for Device:
da0a133 
- Rework urDeviceGetInfoTest to move all enums to their own tests instead of a switch case (oneapi-src#2290)
- Remove the UR/OpenCL enum map function - no point maintaining both a switch case and a separate mapping function
- Update some spec wording for consistency
- Add missing info enums to OpenCL adapater
- Add new urDevicePartition test for checking UR_DEVICE_INFO_PARENT_DEVICE
martygrant added a commit to martygrant/unified-runtime that referenced this issue Dec 19, 2024
@martygrant
Improvements to align CTS and Spec for Device:
e3f06b9 
- Rework urDeviceGetInfoTest to move all enums to their own tests instead of a switch case (oneapi-src#2290)
- Remove the UR/OpenCL enum map function - no point maintaining both a switch case and a separate mapping function
- Update some spec wording for consistency
- Add missing info enums to OpenCL adapater
- Add new urDevicePartition test for checking UR_DEVICE_INFO_PARENT_DEVICE
- Move UUR_RETURN_ON_FATAL_FAILURE and UUR_ASSERT_SUCCESS_OR_UNSUPPORTED to join similar macros in checks.h
This was referenced Dec 19, 2024
Draft
Merged
@martygrant martygrant mentioned this issue Jan 3, 2025
Merged
isaacault added a commit to isaacault/unified-runtime that referenced this issue Jan 6, 2025
@isaacault
Align Kernel CTS and Specification.
f4a279b 
* Separate parameterized tests. Progresses oneapi-src#2290.
* urKernelGetGroupInfo CompileWorkGroupSize test modified to use distinct
  dimensions.
* urKernelSetArgPointer no longer returns invalid argument size.
* Testcases added:
    * urKernelGetGroupInfo CompileMaxWorkGroupSize
    * urKernelGetGroupInfo CompileMaxLinearWorkGroupSize
    * urKernelGetSubGroupInfo CompileNumSubGroups
    * urKernelRetain CheckReferenceCount
    * urKernelRelease CheckReferenceCount
    * urKernelSetArgMemObj InvalidEnumeration
This was referenced Jan 6, 2025
Open
Open
isaacault added a commit to isaacault/unified-runtime that referenced this issue Jan 8, 2025
@isaacault
Align Kernel CTS and Specification.
597717b 
* Separate parameterized tests. Progresses oneapi-src#2290.
* urKernelGetGroupInfo CompileWorkGroupSize test modified to use distinct
  dimensions.
* urKernelSetArgPointer no longer returns invalid argument size.
* Testcases added:
    * urKernelGetGroupInfo CompileMaxWorkGroupSize
    * urKernelGetGroupInfo CompileMaxLinearWorkGroupSize
    * urKernelGetSubGroupInfo CompileNumSubGroups
    * urKernelRetain CheckReferenceCount
    * urKernelRelease CheckReferenceCount
    * urKernelSetArgMemObj InvalidEnumeration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conformance Conformance test suite issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martygrant