From 8e17b32de7830b90788acccd6b48e4d31b3c01a2 Mon Sep 17 00:00:00 2001
From: Jordan Ribbink <jribbink@telus.net>
Date: Fri, 26 Jul 2024 13:21:08 -0700
Subject: [PATCH] Convert frontend to use `/api/wallets`

---
 components/GetWalletCard.tsx         | 23 ++++++------
 components/GetWalletList.tsx         | 11 ++----
 components/ServiceCard.tsx           | 53 ++++++----------------------
 components/ServiceGroup.tsx          | 20 ++++-------
 components/ServiceList.tsx           | 49 +++++++++++++------------
 components/views/WalletSelection.tsx |  2 +-
 hooks/useLastUsedState.tsx           |  9 -----
 hooks/useWalletHistory.tsx           | 26 ++++++++++++++
 hooks/useWallets.ts                  |  7 ++--
 9 files changed, 85 insertions(+), 115 deletions(-)
 delete mode 100644 hooks/useLastUsedState.tsx
 create mode 100644 hooks/useWalletHistory.tsx

diff --git a/components/GetWalletCard.tsx b/components/GetWalletCard.tsx
index 2f97e9c3..0535b74d 100644
--- a/components/GetWalletCard.tsx
+++ b/components/GetWalletCard.tsx
@@ -7,22 +7,19 @@ import {
   HStack,
   Image,
   Stack,
-  Tag,
   Text,
-  Link,
 } from '@chakra-ui/react'
-import { Service } from '../types'
 import NextLink from 'next/link'
+import { Wallet } from '../data/wallets'
 
 type Props = {
-  icon: string
-  name: string
-  service: Service
+  wallet: Wallet
 }
 
-export default function GetWalletCard({ icon, name, service }: Props) {
-  const isExtensionService = isExtension(service)
-  const isExtensionServiceInstalled = Boolean(service?.provider?.is_installed)
+export default function GetWalletCard({ wallet }: Props) {
+  const extensionService = wallet.services.find(isExtension)
+  const isExtensionService = !!extensionService
+  const isExtensionServiceInstalled = extensionService?.provider?.is_installed
 
   return (
     <Card size="md" variant="unstyled">
@@ -31,8 +28,8 @@ export default function GetWalletCard({ icon, name, service }: Props) {
           <Flex alignItems="center" justifyContent="space-between">
             <HStack>
               <Image
-                src={icon}
-                alt={name}
+                src={wallet.icon}
+                alt={wallet.name}
                 borderRadius="lg"
                 borderWidth="1px"
                 borderColor="gray.200"
@@ -43,7 +40,7 @@ export default function GetWalletCard({ icon, name, service }: Props) {
               />
               <Flex direction="column" textAlign="left">
                 <Text fontSize="lg" as="b">
-                  {name}
+                  {wallet.name}
                 </Text>
 
                 {isExtensionService && !isExtensionServiceInstalled ? (
@@ -58,7 +55,7 @@ export default function GetWalletCard({ icon, name, service }: Props) {
 
         {/* TODO: Needs to link to install page, will be addressed in future PR */}
         <Button
-          href={service.provider.install_link || service.provider.website}
+          href={wallet.website}
           target="_blank"
           as={NextLink}
           variant="outline"
diff --git a/components/GetWalletList.tsx b/components/GetWalletList.tsx
index afd1c2cd..33d6fd50 100644
--- a/components/GetWalletList.tsx
+++ b/components/GetWalletList.tsx
@@ -7,15 +7,8 @@ export default function GetWalletList() {
 
   return (
     <Stack spacing={4}>
-      {wallets.map((wallet, index) => {
-        return (
-          <GetWalletCard
-            key={wallet.provider.address ?? index}
-            service={wallet}
-            name={wallet?.provider?.name ?? ''}
-            icon={wallet?.provider?.icon ?? ''}
-          />
-        )
+      {wallets.map(wallet => {
+        return <GetWalletCard key={wallet.uid} wallet={wallet} />
       })}
     </Stack>
   )
diff --git a/components/ServiceCard.tsx b/components/ServiceCard.tsx
index 67b4e5ad..8e6b2d3f 100644
--- a/components/ServiceCard.tsx
+++ b/components/ServiceCard.tsx
@@ -1,7 +1,4 @@
-import { WalletUtils } from '@onflow/fcl'
-import { SUPPORTED_VERSIONS } from '../helpers/constants'
 import { isExtension } from '../helpers/services'
-import { isGreaterThanOrEqualToVersion } from '../helpers/version'
 import {
   Card,
   CardBody,
@@ -12,47 +9,19 @@ import {
   Tag,
   Text,
 } from '@chakra-ui/react'
-import { Service } from '../types'
-import { useConfig } from '../contexts/ConfigContext'
-import { useLastUsedState } from '../hooks/useLastUsedState'
+import { Wallet } from '../data/wallets'
 
-type Props = {
-  icon: string
-  name: string
-  service: Service
+interface ServiceCardProps {
+  wallet: Wallet
 }
 
-export default function ServiceCard({ icon, name, service }: Props) {
-  const { appVersion } = useConfig()
-
-  const installLink = service?.provider?.install_link
-  const isExtensionService = isExtension(service)
-  const isExtensionServiceInstalled = Boolean(service?.provider?.is_installed)
-
-  const { setLastUsed } = useLastUsedState()
+export default function ServiceCard({ wallet }: ServiceCardProps) {
+  const extensionService = wallet.services.find(isExtension)
+  const isExtensionService = !!extensionService
+  const isExtensionServiceInstalled = extensionService?.provider?.is_installed
 
   const onSelect = () => {
-    if (!service) return
-
-    setLastUsed(service?.provider?.address)
-
-    if (isExtensionService && !isExtensionServiceInstalled) {
-      if (installLink) {
-        // Extensions require reload of page to inject script into dapp with data
-        // Redirecting dapp to install page forces page to be refreshed when returning
-        window.parent.location.href = installLink
-      }
-      return
-    }
-
-    if (
-      appVersion &&
-      isGreaterThanOrEqualToVersion(appVersion, SUPPORTED_VERSIONS.EXTENSIONS)
-    ) {
-      WalletUtils.redirect(service)
-    } else {
-      window.location.href = `${service.endpoint}${window.location.search}`
-    }
+    // TODO: implement connect wallet logic, future PR
   }
 
   return (
@@ -73,8 +42,8 @@ export default function ServiceCard({ icon, name, service }: Props) {
             <Flex alignItems="center" justifyContent="space-between">
               <HStack>
                 <Image
-                  src={icon}
-                  alt={name}
+                  src={wallet.icon}
+                  alt={wallet.name}
                   borderRadius="lg"
                   borderWidth="1px"
                   borderColor="gray.200"
@@ -85,7 +54,7 @@ export default function ServiceCard({ icon, name, service }: Props) {
                 />
                 <Flex direction="column" textAlign="left">
                   <Text fontSize="lg" as="b">
-                    {name}
+                    {wallet.name}
                   </Text>
 
                   {isExtensionService && !isExtensionServiceInstalled ? (
diff --git a/components/ServiceGroup.tsx b/components/ServiceGroup.tsx
index 127f2318..7605d222 100644
--- a/components/ServiceGroup.tsx
+++ b/components/ServiceGroup.tsx
@@ -1,17 +1,17 @@
-import { Flex, Stack, Text } from '@chakra-ui/react'
-import { Service } from '../types'
+import { Stack, Text } from '@chakra-ui/react'
 import ServiceCard from './ServiceCard'
+import { Wallet } from '../data/wallets'
 
 interface ServiceGroupProps {
   title: string
-  services: Service[]
+  wallets: Wallet[]
   titleProps?: React.ComponentProps<typeof Text>
   cardProps?: React.ComponentProps<typeof ServiceCard>
 }
 
 export default function ServiceGroup({
   title,
-  services,
+  wallets,
   titleProps,
   cardProps,
 }: ServiceGroupProps) {
@@ -21,16 +21,8 @@ export default function ServiceGroup({
         {title}
       </Text>
       <Stack spacing={2}>
-        {services.map((service, index) => {
-          return (
-            <ServiceCard
-              key={service?.provider?.address ?? index}
-              service={service}
-              name={service?.provider?.name ?? ''}
-              icon={service?.provider?.icon ?? ''}
-              {...cardProps}
-            />
-          )
+        {wallets.map(wallet => {
+          return <ServiceCard key={wallet.uid} wallet={wallet} {...cardProps} />
         })}
       </Stack>
     </Stack>
diff --git a/components/ServiceList.tsx b/components/ServiceList.tsx
index dcfc1fd9..bc713aa5 100644
--- a/components/ServiceList.tsx
+++ b/components/ServiceList.tsx
@@ -1,57 +1,60 @@
 import { Stack } from '@chakra-ui/react'
 import ServiceGroup from './ServiceGroup'
-import { useLastUsedState } from '../hooks/useLastUsedState'
-import { Service } from '../types'
 import { useMemo } from 'react'
+import { Wallet } from '../data/wallets'
+import { isExtension } from '../helpers/services'
+import { useWalletHistory } from '../hooks/useWalletHistory'
 
 interface ServiceListProps {
-  services: Service[]
+  wallets: Wallet[]
 }
 
-export default function ServiceList({ services }: ServiceListProps) {
-  const { lastUsed: lastUsedAddr } = useLastUsedState()
+export default function ServiceList({ wallets }: ServiceListProps) {
+  const { isLastUsed } = useWalletHistory()
 
   // Get the last used service, installed services, and recommended services
-  const { lastUsedService, installedServices, recommendedServices } = useMemo(
+  const { lastUsedWallet, installedWallets, recommendedWallets } = useMemo(
     () =>
-      services.reduce(
-        (acc, service) => {
-          if (service.provider.address === lastUsedAddr && lastUsedAddr) {
-            acc.lastUsedService = service
-          } else if (service.provider.is_installed) {
-            acc.installedServices.push(service)
+      wallets.reduce(
+        (acc, wallet) => {
+          const extensionService = wallet.services.find(isExtension)
+
+          if (isLastUsed(wallet)) {
+            acc.lastUsedWallet = wallet
+          } else if (extensionService?.provider?.is_installed) {
+            acc.installedWallets.push(wallet)
           } else {
-            acc.recommendedServices.push(service)
+            acc.recommendedWallets.push(wallet)
           }
           return acc
         },
         {
-          lastUsedService: null,
-          installedServices: [] as Service[],
-          recommendedServices: [] as Service[],
+          lastUsedWallet: null as Wallet | null,
+          installedWallets: [] as Wallet[],
+          recommendedWallets: [] as Wallet[],
         }
       ),
-    [services, lastUsedAddr]
+    [wallets, isLastUsed]
   )
 
   return (
     <Stack spacing={4}>
-      {lastUsedService && (
+      {lastUsedWallet && (
         <ServiceGroup
           title="Last Used"
-          services={[lastUsedService]}
+          wallets={[lastUsedWallet]}
           titleProps={{
             color: 'blue.400',
           }}
         />
       )}
 
-      {installedServices.length > 0 && (
-        <ServiceGroup title="Installed" services={installedServices} />
+      {installedWallets.length > 0 && (
+        <ServiceGroup title="Installed" wallets={installedWallets} />
       )}
 
-      {recommendedServices.length > 0 && (
-        <ServiceGroup title="Recommended" services={recommendedServices} />
+      {recommendedWallets.length > 0 && (
+        <ServiceGroup title="Recommended" wallets={recommendedWallets} />
       )}
     </Stack>
   )
diff --git a/components/views/WalletSelection.tsx b/components/views/WalletSelection.tsx
index cbfe581b..82650742 100644
--- a/components/views/WalletSelection.tsx
+++ b/components/views/WalletSelection.tsx
@@ -35,7 +35,7 @@ export default function WalletSelection({ onSwitchToLearnMore }: Props) {
         <Stack overflow="scroll" px={8} pb={6} flexGrow={1}>
           {/* TODO: replace this in future PR with Filter Bar */}
           {/*isFeaturesSupported && <Features />*/}
-          <ServiceList services={wallets} />
+          <ServiceList wallets={wallets} />
         </Stack>
 
         <Divider color="gray.300" />
diff --git a/hooks/useLastUsedState.tsx b/hooks/useLastUsedState.tsx
deleted file mode 100644
index b049909b..00000000
--- a/hooks/useLastUsedState.tsx
+++ /dev/null
@@ -1,9 +0,0 @@
-import { LOCAL_STORAGE_KEYS } from '../helpers/constants'
-import { useLocalStorage } from './useLocalStorage'
-
-export function useLastUsedState() {
-  const [, setLastUsed] = useLocalStorage(LOCAL_STORAGE_KEYS.LAST_USED, null)
-  const [lastUsed] = useLocalStorage(LOCAL_STORAGE_KEYS.LAST_USED, null)
-
-  return { lastUsed, setLastUsed }
-}
diff --git a/hooks/useWalletHistory.tsx b/hooks/useWalletHistory.tsx
new file mode 100644
index 00000000..f7dda3dc
--- /dev/null
+++ b/hooks/useWalletHistory.tsx
@@ -0,0 +1,26 @@
+import { useCallback } from 'react'
+import { Wallet } from '../data/wallets'
+import { LOCAL_STORAGE_KEYS } from '../helpers/constants'
+import { useLocalStorage } from './useLocalStorage'
+
+export function useWalletHistory() {
+  const [, setLastUsedState] = useLocalStorage(
+    LOCAL_STORAGE_KEYS.LAST_USED,
+    null
+  )
+  const [lastUsedUid] = useLocalStorage(LOCAL_STORAGE_KEYS.LAST_USED, null)
+
+  const setLastUsed = useCallback(
+    (wallet: Wallet) => {
+      setLastUsedState(wallet.uid)
+    },
+    [setLastUsedState]
+  )
+
+  const isLastUsed = useCallback(
+    (wallet: Wallet) => wallet.uid === lastUsedUid,
+    [lastUsedUid]
+  )
+
+  return { isLastUsed, setLastUsed, lastUsedUid }
+}
diff --git a/hooks/useWallets.ts b/hooks/useWallets.ts
index cdbc66b1..cfc8759f 100644
--- a/hooks/useWallets.ts
+++ b/hooks/useWallets.ts
@@ -1,8 +1,7 @@
 import useSWR from 'swr'
-import { PATHS } from '../helpers/constants'
 import { useConfig } from '../contexts/ConfigContext'
 import { getUserAgent } from '../helpers/platform'
-import { Service } from '../types'
+import { Wallet } from '../data/wallets'
 
 const genKey = (url: string, opts: any) => [url, JSON.stringify(opts)]
 
@@ -27,7 +26,7 @@ export function useWallets() {
     port,
   } = useConfig()
 
-  const requestUrl = `/api${PATHS[network.toUpperCase()]}?discoveryType=UI`
+  const requestUrl = `/api/${network.toLowerCase()}/wallets?discoveryType=UI`
   const body = {
     type: ['authn'],
     fclVersion: appVersion,
@@ -43,7 +42,7 @@ export function useWallets() {
   }
 
   const { data: wallets, error } = useSWR(genKey(requestUrl, body), url =>
-    fetcher<Service[]>(url, body)
+    fetcher<Wallet[]>(url, body)
   )
 
   return { wallets, error, isLoading: !wallets && !error }