-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically assign an ERC721 symbol for bridged NFTs #29
Comments
Since the symbol isn't as important for non-fungible as it is in fungible tokens in all existing products I know of (since they usually just use the full name of the NFT collection in most display references), I am okay with either option 2 or 3 you put up there. I think i'd go with #2 (take first n characters). We should definitely still support and document an optional way to set the symbol yourself in a view though. |
Completed in #52 according to @aishairzay suggestion - slicing the first (up to) 4 alphanumeric characters from the defining contract name. We may revisit this approach in the future when we have some user feedback on which to better inform the decision path forward. For now, the implementation unblocks NFT bridging for those without a symbol defined. In addition, |
Issue To Be Solved
As suggested by @aishairzay in #28 comment, the bridge should enable projects to specify their own ERC721 symbols. However, there isn't a standard metadata view that includes a
symbol
field. One such view was proposed for review, but it can't be counted on that this view will be immediately or even widely implemented if accepted.Suggest A Solution
n
sanitized values of theNFTCollectionDisplay.name
value soExampleNFT Collection
wheren == 6
would beExamp
. This is also not ideal, but at least provides some notion of an identifier. This could be taken further, removing vowels, lower case all characters, etc.EVMBridgedMetadata
. This is certainly not ideal as I'd imagine project want to avoid having the same symbol as others.The text was updated successfully, but these errors were encountered: