Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In pipeline, method countSourceItems must implement count iterator #159

Open
lmikelionis opened this issue Feb 18, 2015 · 2 comments
Open

Comments

@lmikelionis
Copy link
Contributor

So correct overall pipeline item count will be returned.

@mindaugasbarysas
Copy link
Contributor

Iterators returned by pipeline source event listeners should implement Countable interface. Related pull request and an example how to handle this in DBAL is here: ongr-archive/xtCommerceConnectorBundle#39

as far as Doctrine ORM is concerned, these discussions might be of interest:
http://stackoverflow.com/questions/9214471/count-rows-in-doctrine-querybuilder,
http://stackoverflow.com/questions/8226874/symfony2-doctrine-get-number-of-rows-returned-from-datasource
as well as paginator:
http://docs.doctrine-project.org/en/latest/tutorials/pagination.html

@martiis martiis self-assigned this Apr 14, 2015
@martiis
Copy link
Contributor

martiis commented Apr 15, 2015

What if SourcePipelineEvent would also implement countable interface? it would replace countSourceItems method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants