Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

count() on SyncStorageImportIterator returns wrong result #184

Open
tautelis opened this issue Jul 29, 2015 · 0 comments
Open

count() on SyncStorageImportIterator returns wrong result #184

tautelis opened this issue Jul 29, 2015 · 0 comments

Comments

@tautelis
Copy link
Contributor

While running ongr:sync:execute it says there was 1 sync job even if there was none.
$source instance of ONGR\ConnectionsBundle\Sync\SyncStorageImportIterator

Actual items in $source count($source)
0 1
1 1
5 5

For instance here: https://github.com/ongr-io/ConnectionsBundle/blob/d8db145e758479526a8c372905f41773b72d5b7d/Pipeline/Pipeline.php#L201

It should probably implement \countable interface to deliver correct results.
@tautelis tautelis changed the title $source count() returns wrong result count() on SyncStorageImportIterator returns wrong result Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tautelis