Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review message filtering is too aggressive when using multiple window for the same review #128

Open
jsonn opened this issue Aug 28, 2023 · 1 comment

Comments

@jsonn
Copy link

jsonn commented Aug 28, 2023

The current check in

!this.isPlayerController() ||
fails if the controller of a review has multiple views open. This can be two browser windows, but it could also be a different application and a browser window. Just turning the whole condition into true is a significant improvement and would synchronize two browser windows. Markers don't get synchronized correctly though and it would not be possible to have two different locations. So this issue is a bit about what the expected behavior is from a client perspective:

  1. Only synchronize the move tree and update markers iff they affect the current move
  2. Keep the board state fully synced
@jsonn
Copy link
Author

jsonn commented Aug 29, 2023

From the discussion with some broadcasters, the first would generally be the more useful behavior. I'm looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant