Add type stubs for Cython files #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings the signature in line with how Python defines the operator. The modulo parameter was not used.
MaxHalford
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding type stubs for C extension modules enables type checker to verify the calls made to these modules. They are ignored by the Python interpreter when running the program.
The type stubs here are not all type-complete.
Their addition also allows re-enabling missing imports checks for the
riverpackage. Without the stubs, checkers like MyPy would complain about not being able to find the C extension modules.I also fixed the definition of
__pow__fromvectordict.pyxto bring it in line with its signature in Python. Themoduloparameter was unused.