Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at #1417.
Some commits have already been done about this, but a few uses were left in the code.
I added type hints for the
learn_one
,learn_many
,update
, andrevert
methods in the base classes, meaning MyPy can now be used to detect child classes with the wrong return type.I believe the only
update
method with a non-None return is the one in LazySearch, I think the boolean is voluntary and has a use case.Since the original discussion was about update-like methods in general, I also updated a few methods like
_fit
where it didn't break the logic.