Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cairo lint and format pre-commits #10

Open
AbdelStark opened this issue May 3, 2022 · 0 comments
Open

Add cairo lint and format pre-commits #10

AbdelStark opened this issue May 3, 2022 · 0 comments

Comments

@AbdelStark
Copy link
Contributor

AbdelStark commented May 3, 2022 •
edited
Loading

Description

Ideally we want to prevent commits with lint issues or bad formatting. Currently we do this kind of checks on the continuous integration.

We can use pre-commit-cairo. It uses Armana static analyzer under the hood.

Acceptance criteria

  • commits with lint issues are rejected
  • commits with formatting issues are rejected

Requirements

  • Install pre-commit on local dev environment
  • Install armana on local dev environment

We should update README file to add the requirements instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add cairo lint and format pre-commits
2 participants
@ofux @AbdelStark