Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add end-to-end testing #30

Open
Clement-Brottier opened this issue May 11, 2022 · 0 comments
Open

Add end-to-end testing #30

Clement-Brottier opened this issue May 11, 2022 · 0 comments
Labels
Context: coupled interact with some parts of the codebase Difficulty: intermediate mobilise some notions about the field, but can be learned while doing Duration: few days will take a few days State: open ready for contribution Techno: cairo cairo Type: test improve testing coverage

Comments

@Clement-Brottier
Copy link

Clement-Brottier commented May 11, 2022 •
edited by ofux
Loading

User story

https://www.notion.so/onlydust/As-a-developer-I-want-to-test-my-application-end-to-end-13246b31021548a79bcafa9919f351cc

Description

The project already contains some unit tests, but it misses end-to-end tests.
As a developer, I want to know if everything is working well together, without the need to deploy & test manually.

Write a protostar test that will actually deploy all contracts and test the tournament from an end-user perspective.

Acceptance Criteria

  • the test must be deterministic. Random-generator contract will have to be mocked for this reason.
  • the test must deploy and run an entire tournament with 2 ships per battle, 8 ships in total and a grid size of 10.
  • you may use basic_ship and/or static_ship implementations in the test. You may also implement a specific ship for the test, if you feel it is needed.
  • the test must assert the stage of the tournament is correct at each step.
  • the test must assert who the winner is.
@ofux ofux changed the title Add end-to-end testing when deploying app Add end-to-end testing May 16, 2022
@ofux ofux added Type: test improve testing coverage Difficulty: hard require extensive knowledge about the field State: open ready for contribution Duration: few days will take a few days Context: coupled interact with some parts of the codebase Techno: cairo cairo Difficulty: intermediate mobilise some notions about the field, but can be learned while doing and removed Difficulty: hard require extensive knowledge about the field labels May 17, 2022
@ArnaudBger ArnaudBger mentioned this issue Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Context: coupled interact with some parts of the codebase Difficulty: intermediate mobilise some notions about the field, but can be learned while doing Duration: few days will take a few days State: open ready for contribution Techno: cairo cairo Type: test improve testing coverage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ofux @Clement-Brottier