Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built from Source: Stops Tree Loading #39

Closed
Pop000100 opened this issue Mar 27, 2023 · 12 comments
Closed

Built from Source: Stops Tree Loading #39

Pop000100 opened this issue Mar 27, 2023 · 12 comments

Comments

@Pop000100
Copy link

Pop000100 commented Mar 27, 2023

First of all, if you know and don't want any feedback on the unreleased version tell me ill close this issue and ill leave you alone.
with that out of the way my issue is:
Stops trees from loading after running far away from start of session. they sometimes pop in.

I appreciated this mod, glad to see some work on it.

@ontrigger
Copy link
Owner

Can you try this version? The github commits are outdated
https://cdn.discordapp.com/attachments/1085880046956335145/1088015731347689472/vpo-1.0.0-a3.zip

@ontrigger
Copy link
Owner

Do note that this is for the latest ptb only

@Pop000100
Copy link
Author

Pop000100 commented Mar 28, 2023

did you actually optimize the standard unity libraries as well, I added the included ones as refs didn't know the changes?

Test: that causes CTD
LogOutput.log

RX 6700xt
9900k
Windows 10

Note: I can build code and have a pretty good understanding of C# but rendering code isn't my specialty
I wouldn't mind helping if you need AMD GPU help. Since you sound like you have NVIDIA GPU(I have read all the issues)
Not sure how much help I would be but I am willing to try to debug AMD driver issues.

@ontrigger
Copy link
Owner

The libs in the data folder were not in the game by default, so I had to include them in the dl. On a related note, I might have forgotten to update said libs to the new unity version, which is why you're probably getting the ctd and I'm not (I replaced all the dlls in my folder with unity ones)

@ontrigger
Copy link
Owner

Test: that causes CTD LogOutput.log

This kind of looks like a bepinex problem. Here's someone reporting the exact same issue with V+: valheimPlus/ValheimPlus#800
The new update caused a shitload of issues with the preloader, forcing the community to update the pack to a new version.

https://cdn.discordapp.com/attachments/826573164371902467/1088128708285583391/denikson-BepInExPack_Valheim-5.4.2101.zip

I've also just checked the libs and it seems like they do not need to be updated

@Pop000100
Copy link
Author

updating BepInEx fixes the CTD but trees are still not loading.
This is what it looks like
bug
Reloading works
reload
This is a log when I encounter it
LogOutput.log

@ontrigger
Copy link
Owner

Was able to reproduce. It seems like distant objects don't want to be spawned in a near area.

@Pop000100
Copy link
Author

Good, Now that the update dropped I can disable the public test right? Or are you always going to be targeting that?

@ontrigger
Copy link
Owner

I will always target the latest patch, but you should be fine on main for now as it is identical to ptb.
I'll be able to fix it tomorrow; looks like a simple oversight from what I understand

@Pop000100
Copy link
Author

Even if it has unstability?

@ontrigger
Copy link
Owner

ontrigger commented Mar 29, 2023

Should be fixed now. Here's the test version
vpo-1.0.0-a4.zip

Even if it has unstability?

So what if it's unstable? You can always use a previous version of VPO that is compatible with a PTB as every update on the test branch will eventually become stable anyway. The latest version targets the latest ptb yet is fully compatible with the stable branch.

@Pop000100
Copy link
Author

It seems to be fixed.

Repository owner locked and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants