Filter on text input

[bkniffler]

Hey,
Great plugin!

Currently this plugin doesn't seem to filter items based on what you type after @, e.g. @jo. What would be really cool is a function onFilter that would get the current text and could return a filtered list of items or even fetch new items asynchronously through promise/callback.

What do you think?

edit: Ah, there seems to be such a functionality, need to check it properly.

[aunswjx]

Thanks @bkniffler

I think the current implementation of getting the current text is complicate and I think we could make it better. I do like you idea about updating suggestion item via asynchronous call, but I couldn't about a solid solution right now. Currently, what I can think of is adding some kind of setter function of suggestion items to the plugin and pass it to the portal.

What do you think?

Will reopen this issue.

[bkniffler]

Hey, my suggestion would be to allow suggestions to be a function that could return an array or a promise, with an argument being the current input (e.g. jon-). Also, on a side note, I would drop either trigger or match, since they do similar things (one being responsible to trigger the whole thing, the other getting the matched text, but they could easily be one regex with @ being default).

[aunswjx]

Thank you for your suggestion.

From you suggestion I break it down into the following
New feature

• Make suggestions prop retrieve value from a function that returns an array or a promise.
• That function should have current text input as an argument.

Refactor

• I would drop capture regex since match capture is not really useful.

What do you think? @bkniffler it would be very appreciate, If you could help me on this feature.

[bkniffler]

Okay, and I'd try and make use of slate onChange to extrapolate the current input for suggestions. I'll give it a try on weekend.

[oyeanuj]

Also very interested in this - especially suggestions being a function with the user typed input! @bkniffler let us know if there is even a WIP that one could look at for inspiration.

[bkniffler]

Hey @oyeanuj, unfortunately I didn't have the opportunity yet. But its on my backlog as I really need this to work. So if you guys want to give it a shot, go on! If not, expect to see something in the coming weeks :)

[scf4]

@bkniffler Any update? This would seem like basic functionality for such a plugin?

[marekolszewski]

@bkniffler @aunsuwijak I created a PR that adds support for this, but without removing the capture prop. Simply set your suggestions prop to a function that takes the string to be autocompleted and returns a promise, which then resolves to an array matching the existing suggestions prop format.

I've testing it against the Facebook Graph API and the suggestions come in very quickly.