Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] combine audio2text with asr service #905

Open
lianhao opened this issue Nov 15, 2024 · 1 comment
Open

[Feature] combine audio2text with asr service #905

lianhao opened this issue Nov 15, 2024 · 1 comment
Assignees

Comments

@lianhao
Copy link
Contributor

lianhao commented Nov 15, 2024

Priority

Undecided

OS type

Ubuntu

Hardware type

Xeon-GNR

Running nodes

Single Node

Description

The audio2text service is almost the same as the asr service, except for the returned data object type. We should combine both of them to minimize maintenance effort

@Spycsh Spycsh self-assigned this Nov 20, 2024
@Spycsh
Copy link
Member

Spycsh commented Nov 20, 2024

Hi @lianhao due to a legacy issue huggingface/tokenizers#187, the first implementation of these ASR/TTS code is to split the microservice start and the model initialization to different places. Basically it is because our microservice are initialized in the other process using register_microservice and the huggingface tokenizer just fail with that case.

It is a bit annoying before I finally get some solutions to avoid such situations. I fully agree we should combine these two services together and remove the wrapper, same to tts service. I am starting to look into this together with the OpenAI format compatible feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants