From 080f3d2cd473c09ec252a6ffb23f1a5e7486943b Mon Sep 17 00:00:00 2001 From: Qing Hao Date: Thu, 12 Oct 2023 02:52:44 -0500 Subject: [PATCH] deprecate WithInstallStrategy (#213) Signed-off-by: haoqing0110 --- pkg/addonfactory/addonfactory.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/addonfactory/addonfactory.go b/pkg/addonfactory/addonfactory.go index 21d6de39f..c578634f3 100644 --- a/pkg/addonfactory/addonfactory.go +++ b/pkg/addonfactory/addonfactory.go @@ -78,6 +78,8 @@ func (f *AgentAddonFactory) WithGetValuesFuncs(getValuesFuncs ...GetValuesFunc) } // WithInstallStrategy defines the installation strategy of the manifests prescribed by Manifests(..). +// Deprecated: add annotation "addon.open-cluster-management.io/lifecycle: addon-manager" to ClusterManagementAddon +// and define install strategy in ClusterManagementAddon spec.installStrategy instead. func (f *AgentAddonFactory) WithInstallStrategy(strategy *agent.InstallStrategy) *AgentAddonFactory { if strategy.InstallNamespace == "" { strategy.InstallNamespace = AddonDefaultInstallNamespace