Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndexManifestWorkByAddon ? #222

Open
tamalsaha opened this issue Nov 6, 2023 · 2 comments
Open

IndexManifestWorkByAddon ? #222

tamalsaha opened this issue Nov 6, 2023 · 2 comments

Comments

@tamalsaha
Copy link
Contributor

if len(addonName) == 0 || len(addonNamespace) > 0 || isHook {

if len(addonName) == 0 || len(addonNamespace) > 0 || isHook {
		return []string{}, nil
	}

Should len(addonNamespace) > 0 be len(addonNamespace) == 0 ?

@qiujian16
Copy link
Member

cc @zhiweiyin318

@zhiweiyin318
Copy link
Member

@tamalsaha IndexManifestWorkByAddon is only to filter default mode addon manifestworks.
addonNamespace is got from label, that means the addon is hosted mode if addonNamespace is not empty.
we need comments for understanding here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants