Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dynamically defining the elements in the ProbeFields #288

Open
JoaoBraveCoding opened this issue Nov 22, 2024 · 2 comments

Comments

@JoaoBraveCoding
Copy link
Contributor

JoaoBraveCoding commented Nov 22, 2024

Request/Feature

Support for dynamically defining the ProbeFields on a per placement or managed cluster basis.

Use case

The observability group continues to develop the MultiClusterObservabilityAddon (MCOA), this addon has the ability to selectively deploy different observability signals collectors to different spoke clusters. Some observability deployment can be rather complex so we would want the ability to let users know if their deployments have been successful. To achieve this we started using the AgentHealthProber of type HealthProberTypeWork. Unfortunately this probe only supports a fixed list of ProbeFields which is not sufficient for our use case given some clusters might just want metrics while others might want metrics and logs.

@zhiweiyin318
Copy link
Member

zhiweiyin318 commented Nov 23, 2024

This requirement is similar with #287
I have a PR #289 to address this.
In the PR, support wildcard in the name and namespace of ProbeField.ResourceIdentifier (depend on this open-cluster-management-io/ocm#705), and add another func HealthChecker to WorkHealthProber which can check all feedback results at once.
@JoaoBraveCoding could you help check if this can address your case?

@JoaoBraveCoding
Copy link
Contributor Author

@zhiweiyin318 thank you for the quick work! I've already drafted a PR and tested this and it seems to do the job! I'll double check with the team to be sure 👍 Great work! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants