Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use projen native TextFile features for generated files #281

Merged
merged 12 commits into from
Jan 15, 2024

Conversation

hoegertn
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message describes your change
  • Tests for the changes have been added if possible (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Changes are mentioned in the changelog (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    cdk-serverless now uses projen's native feature of TextFile components instead of writing files to disk manually

  • What is the current behavior? (You can also link to an open issue here)
    cdk-serverless uses fs.writeFileSync to write generated files

  • What is the new behavior (if this is a feature change)?
    cdk-serverless uses pj.TextFile to generate files with the correct lifecycle

  • Does this PR introduce a breaking change? (What changes might users need to make in their setup due to this PR?)

  • Other information:

@hoegertn
Copy link
Contributor Author

@DerDackel as mentioned I move the file generation to projen's native components.

No idea why I did not do this before.

@hoegertn hoegertn self-assigned this Jan 15, 2024
Copy link
Contributor

@DerDackel DerDackel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoegertn hoegertn merged commit cdd33b0 into main Jan 15, 2024
7 checks passed
@hoegertn hoegertn deleted the feature/managed-files branch January 15, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants