Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many procedure data fields also apply to lots #58

Closed
ColinMaudry opened this issue Aug 18, 2021 · 7 comments
Closed

Many procedure data fields also apply to lots #58

ColinMaudry opened this issue Aug 18, 2021 · 7 comments
Labels
tidy-up Issues that we need to check mappings against

Comments

@ColinMaudry
Copy link
Member

ColinMaudry commented Aug 18, 2021

A lot of BT that can describe the whole procedure can also describe individual lots. This is very much visible in the XML, where the element that describes the general information of a procedure (cac:ProcurementProject) is also a child of cac:ProcurementProjectLot that describes a lot, bringing all its own children elements.

Rough XML structure of an eForms document:

<[form type]>
     <cac:ProcurementProject>
         general information on the procedure...
     </cac:ProcurementProject>
     <cac:ProcurementProjectLot>
          <cac:ProcurementProject>
               general information on lot 1...
          </cac:ProcurementProject>
          other information on lot 1
     </cac:ProcurementProjectLot>
     <cac:ProcurementProjectLot>
          <cac:ProcurementProject>
               general information on lot 2...
          </cac:ProcurementProject>
          other information on lot 2
     </cac:ProcurementProjectLot>
     ...
</[form type]>

For example, the two possible xpaths for BT-24 (Description) and their respective mapping in OCDS:

  • /*/cac:ProcurementProject/cbc:Description => tender.description
  • /*/cac:ProcurementProjectLot/cac:ProcurementProject/cbc:Description => Lot.description

From a quick scan in the mapping data, BT that have an xpath that starts with/*/cac:ProcurementProject almost always have also an xpath that starts with /*/cac:ProcurementProjectLot/cac:ProcurementProject. On the other hand, many BT only have an xpath that starts with /*/cac:ProcurementProjectLot, meaning the XML schemas of eForms are rather centered on lots.

@jpmckinney What's the status of the thinking around the extension of the Lot object in OCDS? I think we're going to need it for data such as:

  • description (general description of the procurement)
  • procurement category (works, services, supplies) + additional
  • classification (CPV, etc) + additional
  • contract period
  • (more examples incoming)
@ColinMaudry ColinMaudry self-assigned this Aug 18, 2021
@jpmckinney
Copy link
Member

Yes, in general, I am fine with adding fields from Tender to Lot.

@ColinMaudry
Copy link
Member Author

I will write guidance with new fields in Lot, and when the guidance is stable we implement them.

@ColinMaudry
Copy link
Member Author

ColinMaudry commented Dec 10, 2021

There are cases, such as BT-23 Main Nature, where a BT can either be in /cac:ProcurementProjectLot (applies to the lot) or in /cac:ProcurementProject (whole procedure).

So far I write guidance with mapping to the OCDS lot as long as /cac:ProcurementProjectLot can be an ancestor. That's what I did with BT-23 Main Nature.

That's because I think it's simpler if fields that may map to a lot always map to a lot, even if there is only one.

@ColinMaudry
Copy link
Member Author

On second thought, it may be strange if certain tender fields, such as tender.description, are empty in single lot situations. We could instruct implementers to mirror all applicable fields from the lot to tender in single lot situations.

@jpmckinney
Copy link
Member

I'm fine with only data in lots. Having duplicate information can be confusing and create room for error. See also discussion in open-contracting/standard#891

@ColinMaudry ColinMaudry removed their assignment Dec 13, 2021
@jpmckinney jpmckinney removed the eforms label Jul 7, 2022
@jpmckinney
Copy link
Member

@duncandewhurst @odscjen I think your mapping work follows the pattern of putting data in the lot (even if there is only one "virtual" lot), but just want to double-check before closing this issue (e.g. maybe early on this wasn't well established yet?).

@jpmckinney jpmckinney added the tidy-up Issues that we need to check mappings against label Jan 12, 2023
@odscjen
Copy link
Contributor

odscjen commented Jan 13, 2023

@jpmckinney yes that's right, I think we agreed on that fairly early on when we were still reviewing Colin's [UNREVIEWED] mappings so I think this issue can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tidy-up Issues that we need to check mappings against
Projects
None yet
Development

No branches or pull requests

3 participants