-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many procedure data fields also apply to lots #58
Comments
Yes, in general, I am fine with adding fields from Tender to Lot. |
I will write guidance with new fields in Lot, and when the guidance is stable we implement them. |
There are cases, such as BT-23 Main Nature, where a BT can either be in So far I write guidance with mapping to the OCDS lot as long as That's because I think it's simpler if fields that may map to a lot always map to a lot, even if there is only one. |
On second thought, it may be strange if certain |
I'm fine with only data in lots. Having duplicate information can be confusing and create room for error. See also discussion in open-contracting/standard#891 |
@duncandewhurst @odscjen I think your mapping work follows the pattern of putting data in the lot (even if there is only one "virtual" lot), but just want to double-check before closing this issue (e.g. maybe early on this wasn't well established yet?). |
@jpmckinney yes that's right, I think we agreed on that fairly early on when we were still reviewing Colin's [UNREVIEWED] mappings so I think this issue can be closed now. |
A lot of BT that can describe the whole procedure can also describe individual lots. This is very much visible in the XML, where the element that describes the general information of a procedure (
cac:ProcurementProject
) is also a child ofcac:ProcurementProjectLot
that describes a lot, bringing all its own children elements.Rough XML structure of an eForms document:
For example, the two possible xpaths for BT-24 (Description) and their respective mapping in OCDS:
/*/cac:ProcurementProject/cbc:Description
=>tender.description
/*/cac:ProcurementProjectLot/cac:ProcurementProject/cbc:Description
=>Lot.description
From a quick scan in the mapping data, BT that have an xpath that starts with
/*/cac:ProcurementProject
almost always have also an xpath that starts with/*/cac:ProcurementProjectLot/cac:ProcurementProject
. On the other hand, many BT only have an xpath that starts with/*/cac:ProcurementProjectLot
, meaning the XML schemas of eForms are rather centered on lots.@jpmckinney What's the status of the thinking around the extension of the Lot object in OCDS? I think we're going to need it for data such as:
The text was updated successfully, but these errors were encountered: