New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React router cleanup #626

Closed

pi0neerpat opened this issue Jul 10, 2024 · 0 comments · Fixed by #602

Assignees

Labels

ch-39

Member

pi0neerpat commented Jul 10, 2024 •

edited

Loading

In #602, update the way we handle path variables to use consistent method: useMatch or useParams

Docs: https://reactrouter.com/en/main/hooks/use-params
https://reactrouter.com/en/main/start/overview

In VaultDetails: const safeId = props.match.params.id as string
In EarnDetails
Elsewhere that path is being read

The text was updated successfully, but these errors were encountered:

pi0neerpat added the ch-39 label

pi0neerpat assigned jahabeebs

pi0neerpat mentioned this issue

Update react, react-router #602

Merged

pi0neerpat closed this as completed in #602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment