Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for any (round 2) #654

Open
pi0neerpat opened this issue Jul 23, 2024 · 2 comments
Open

Add types for any (round 2) #654

pi0neerpat opened this issue Jul 23, 2024 · 2 comments

Comments

@pi0neerpat
Copy link
Member

pi0neerpat commented Jul 23, 2024

Add types wherever ts-ignore is used

sven-so added a commit to sven-so/od-app that referenced this issue Dec 10, 2024
Related to open-dollar#654

Just a test for copilot workspace. 
Let copilot generate everything. Not yet tried out

Add types to replace `ts-ignore` comments in various files.

* **cypress/support/commands.ts**
  - Add types for `sendAsync` and `send` methods in `CustomizedBridge` class.
  - Import `TransactionRequest` and `TransactionResponse` from `@ethersproject/providers`.

* **src/abis/common.ts**
  - Add types for `TypedListener` type definition.

* **src/abis/Erc20.ts**
  - Remove `@ts-ignore` from import statements.

* **src/components/ConnectedWalletInfo.tsx**
  - Add return type for `formatConnectorName` function.

* **src/components/Icons/Identicon.tsx**
  - Remove `@ts-ignore` from import statement.

* **src/components/Modals/ProxyModal.tsx**
  - Add type for `signer` in `handleCreateAccount` function.

* **src/connectors/index.ts**
  - Remove `@ts-ignore` comments and add types for `walletconnect` initialization.

* **src/hooks/useContract.ts**
  - Add types for `useContract` function and remove `@ts-ignore` comments.

* **src/utils/constants.ts**
  - Add types for `geb` export and remove `@ts-ignore` comments.
@sven-so
Copy link

sven-so commented Dec 10, 2024

@pi0neerpat : sry, didn't know, that it is directly linked with your repo. Just wanted to try something. Please ignore. Won't happen again.

@pi0neerpat
Copy link
Member Author

Would you like to help with this PR? We would love to have your support. AI assisted PRs are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants