Add types for any (round 2) #676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to open-dollar#654 Just a test for copilot workspace. Let copilot generate everything. Not yet tried out Add types to replace `ts-ignore` comments in various files. * **cypress/support/commands.ts** - Add types for `sendAsync` and `send` methods in `CustomizedBridge` class. - Import `TransactionRequest` and `TransactionResponse` from `@ethersproject/providers`. * **src/abis/common.ts** - Add types for `TypedListener` type definition. * **src/abis/Erc20.ts** - Remove `@ts-ignore` from import statements. * **src/components/ConnectedWalletInfo.tsx** - Add return type for `formatConnectorName` function. * **src/components/Icons/Identicon.tsx** - Remove `@ts-ignore` from import statement. * **src/components/Modals/ProxyModal.tsx** - Add type for `signer` in `handleCreateAccount` function. * **src/connectors/index.ts** - Remove `@ts-ignore` comments and add types for `walletconnect` initialization. * **src/hooks/useContract.ts** - Add types for `useContract` function and remove `@ts-ignore` comments. * **src/utils/constants.ts** - Add types for `geb` export and remove `@ts-ignore` comments.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@sven-so is attempting to deploy a commit to the Open Dollar Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #654
Just a test for copilot workspace.
Let copilot generate everything. Not yet tried out
Add types to replace
ts-ignorecomments in various files.cypress/support/commands.ts
sendAsyncandsendmethods inCustomizedBridgeclass.TransactionRequestandTransactionResponsefrom@ethersproject/providers.src/abis/common.ts
TypedListenertype definition.src/abis/Erc20.ts
@ts-ignorefrom import statements.src/components/ConnectedWalletInfo.tsx
formatConnectorNamefunction.src/components/Icons/Identicon.tsx
@ts-ignorefrom import statement.src/components/Modals/ProxyModal.tsx
signerinhandleCreateAccountfunction.src/connectors/index.ts
@ts-ignorecomments and add types forwalletconnectinitialization.src/hooks/useContract.ts
useContractfunction and remove@ts-ignorecomments.src/utils/constants.ts
gebexport and remove@ts-ignorecomments.