Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call the simulated imu_gyro_value for device #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShahramKhorshidi
Copy link

@ShahramKhorshidi ShahramKhorshidi commented Nov 25, 2021

Call the simulated value of imu_gyro from PinBulletWrapper for device

Tested in simulation with ekf class to estimate the base states from noisy imu_readings

I fulfilled the following requirements

  • All new code is formatted according to our style guide (for C++ run clang-format, for Python, run flake8 and fix all warnings).
  • All new functions/classes are documented and existing documentation is updated according to changes.
  • No commented code from testing/debugging is kept (unless there is a good reason to keep it).

@jviereck jviereck self-requested a review November 29, 2021 14:56
Copy link
Contributor

@MaximilienNaveau MaximilienNaveau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be better no?

@MaximilienNaveau
Copy link
Contributor

@jviereck do you confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants