Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make channel selection smoother for all channel configuration dialogs #373

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

bparks13
Copy link
Member

If multiple probes exist, ensures that the contact index is correctly grabbed.

Better differentiates between clicks and click-and-drag events so it is easier to select / deselect contacts.

Fixes #354

- If the selection rectangle is smaller than any given contact, try to select a single contact based on the mouse position instead
- Added support for `ContactShape.Rect`
@bparks13 bparks13 added the enhancement This feature already exists but could be improved label Nov 12, 2024
@bparks13 bparks13 added this to the 0.4.1 milestone Nov 12, 2024
@bparks13 bparks13 requested a review from jonnew November 12, 2024 20:24
@bparks13 bparks13 self-assigned this Nov 12, 2024
@jonnew jonnew merged commit d9a0c87 into main Nov 14, 2024
7 checks passed
@jonnew jonnew deleted the issue-354 branch November 14, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This feature already exists but could be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easier to click to select/deselect channels in ChannelConfigurationDialog
2 participants