Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notifications: smoother notifications ( fixes #4955) #4962

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

notifications: smoother notifications ( fixes #4955) #4962

wants to merge 2 commits into from
+13 −7

Conversation

deeppp15
Copy link
Member

@deeppp15 deeppp15 commented Jan 8, 2025 •
edited by Okuro3499
Loading

Description

Screenshot

Screenshot_20250108_161505

@deeppp15 deeppp15 requested a review from Okuro3499 January 8, 2025 00:19
Okuro3499
Okuro3499 requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this new task in the notification is written as new is due in task...
Screenshot_20250108_162147

pavi38
pavi38 reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@pavi38 pavi38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem is persistent, if the name of the task contains a blank space.

Screenshot 2025-01-08 at 11 08 44 AM

Avinash-Codes
Avinash-Codes requested changes Jan 8, 2025
View reviewed changes
Copy link
Member

@Avinash-Codes Avinash-Codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue still persist
Screenshot_20250108_235342

@deeppp15
Copy link
Member Author

deeppp15 commented Jan 8, 2025

Added regex matching
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Okuro3499 Okuro3499 Okuro3499 approved these changes

@Avinash-Codes Avinash-Codes Awaiting requested review from Avinash-Codes

@pavi38 pavi38 Awaiting requested review from pavi38

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
peer review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

confusing notification message
4 participants
@deeppp15 @Okuro3499 @pavi38 @Avinash-Codes