New 'Lr' Scheduler Issue

[sakerlrf]

Hello,

Trying to add RelativeStepLrUpdaterHook, but I am confused with the folders in the core.

• In this current rep online, I see that inside the core, there is no lr folder. Instead, there is only the scheduler, holding the lr_updater.py; having a general name even though it refers to specific scheduler!?
• In the docs, the path is suggested: $MMAction2/mmaction/core/lr

While in mmcv/mmcv/runner/hooks/lr_updater.py, the 'lr_updater.py' has all the registered schedulers.

Adding the scheduler

For the addition, the steps I took were to create the RelativeStep_lr_hook.py, in "mmaction/core/lr" and import the enclosed class to __init__.py in the same dir.
When I set the lr_config, in the model config script and try to train a model, I get:

TypeError: RelativeStepLrUpdaterHook: __init__() missing 1 required positional argument: 'runner'

Any input would be helpful.
Thanks!

[dreamerlin]

1. Thanks for your report. the dir has changed to core/scheduler. We will update it soon.
2. you forget to pass runner to __init__.

[sakerlrf]

Thank you for your answer @dreamerlin. Here is what I have in the init.py:

from .RelativeStep_lr_hook import RelativeStepLrUpdaterHook
__all__ = ['RelativeStepLrUpdaterHook']

[sakerlrf]

@dreamerlin, Could you please demonstrate what should be added?
Do you possibly refer to the 'base_runner'?

Thank you.

[dreamerlin]

Oops ... The runner should not be in __init__. Thanks for your report, we will update it

[dreamerlin]

9dab331