Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

height and width in Resize pipeline are misplaced #209

Open
makecent opened this issue Jan 8, 2022 · 2 comments · May be fixed by #211
Open

height and width in Resize pipeline are misplaced #209

makecent opened this issue Jan 8, 2022 · 2 comments · May be fixed by #211
Assignees
@LeoXing1996
Labels
kind/bug something isn't working priority/P0 highest priority
Milestone
0.8.0

Comments

@makecent
Copy link

makecent commented Jan 8, 2022

Reproduction

from mmgen.datasets.pipelines import Resize, LoadImageFromFile
results = {'real_img_path': 'path-to-img/0001.jpg'}
t = LoadImageFromFile(key='real_img', io_backend='disk')(results)
tt = Resize(keys=['real_img'], scale=(128, 32), keep_ratio=False)(t)

Bug fix
I think it's because mmcv.imresize uses (width, heights) for the scale argument.
@makecent makecent changed the title height and width in Resize pipeline are got misplaced height and width in Resize pipeline are misplaced Jan 8, 2022
@LeoXing1996
Copy link
Collaborator

Hey @makecent , thanks for your interest in our project.
We will fix this recently. We would also be glad that if you could create a pull request to fix this.

@makecent makecent linked a pull request Jan 9, 2022 that will close this issue
Open
@makecent
Copy link
Author

makecent commented Jan 9, 2022

Hey @makecent , thanks for your interest in our project. We will fix this recently. We would also be glad that if you could create a pull request to fix this.

I just made a PR.

@zengyh1900 zengyh1900 added this to the 0.8.0 milestone Oct 12, 2022
@zengyh1900 zengyh1900 added kind/bug something isn't working awaiting response priority/P0 highest priority and removed awaiting response labels Oct 12, 2022
@zengyh1900 zengyh1900 removed the PRed label Oct 20, 2022
LeoXing1996 pushed a commit to LeoXing1996/mmgeneration that referenced this issue Oct 27, 2022
@yaochaorui
Pipelines for FBA (open-mmlab#209)
4f90c0c 
* Added pipelines for FBA.

* Modified.

* Added test.

* Tiny.

* Added __repr__  funcs.

* Added use_cache.

* Added test.

* Tiny.

* Added unittest.

* Speed up via broadcasting.

* Tiny.

* Use online cache.

* Tiny.

* Tiny.

* Simplified.

* Tiny。

* Tiny.

* Tiny.

* Tiny.

* Polished the doc string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeoXing1996 LeoXing1996

Labels
kind/bug something isn't working priority/P0 highest priority
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

Correct Resize pipeline makecent/mmgeneration
3 participants
@zengyh1900 @LeoXing1996 @makecent