adding constructor for vapbinding name

Signed-off-by: Jaydip Gabani <[email protected]>
open-policy-agent · Nov 22, 2024 · a1481e8 · a1481e8
1 parent 32f4591
commit a1481e8
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/pkg/controller/constraint/constraint_controller.go b/pkg/controller/constraint/constraint_controller.go
@@ -370,7 +370,7 @@ func (r *ReconcileConstraint) Reconcile(ctx context.Context, request reconcile.R
 			if err != nil {
 				return reconcile.Result{}, err
 			}
-			vapBindingName := fmt.Sprintf("gatekeeper-%s", instance.GetName())
+			vapBindingName := getVAPBindingName(instance.GetName())
 			currentVapBinding.SetName(vapBindingName)
 			if err := r.writer.Delete(ctx, currentVapBinding); err != nil {
 				if !apierrors.IsNotFound(err) {
@@ -567,7 +567,7 @@ func (r *ReconcileConstraint) manageVAPB(ctx context.Context, enforcementAction
 		if err != nil {
 			return noDelay, r.reportErrorOnConstraintStatus(ctx, status, err, "could not get ValidatingAdmissionPolicyBinding API version")
 		}
-		vapBindingName := fmt.Sprintf("gatekeeper-%s", instance.GetName())
+		vapBindingName := getVAPBindingName(instance.GetName())
 		log.Info("check if vapbinding exists", "vapBindingName", vapBindingName)
 		if err := r.reader.Get(ctx, types.NamespacedName{Name: vapBindingName}, currentVapBinding); err != nil {
 			if !apierrors.IsNotFound(err) {
@@ -609,7 +609,7 @@ func (r *ReconcileConstraint) manageVAPB(ctx context.Context, enforcementAction
 		if err != nil {
 			return noDelay, r.reportErrorOnConstraintStatus(ctx, status, err, "could not get ValidatingAdmissionPolicyBinding API version")
 		}
-		vapBindingName := fmt.Sprintf("gatekeeper-%s", instance.GetName())
+		vapBindingName := getVAPBindingName(instance.GetName())
 		log.Info("check if vapbinding exists", "vapBindingName", vapBindingName)
 		if err := r.reader.Get(ctx, types.NamespacedName{Name: vapBindingName}, currentVapBinding); err != nil {
 			if !apierrors.IsNotFound(err) && !errors.As(err, &discoveryErr) && !meta.IsNoMatchError(err) {
@@ -767,3 +767,7 @@ func cleanEnforcementPointStatus(status *constraintstatusv1beta1.ConstraintPodSt
 		}
 	}
 }
+
+func getVAPBindingName(constraintName string) string {
+	return fmt.Sprintf("gatekeeper-%s", constraintName)
+}