New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncsets: improve replay #2983

Closed

acpana opened this issue Aug 31, 2023 · 0 comments · Fixed by #2984

Assignees

Labels

SyncSet Related

Contributor

acpana commented Aug 31, 2023 •

edited

Loading

In support of the sync set proposal

There were some outstanding concerns raised on #2852

In particular,

feat: support multiple sync sources #2852 (comment)

If the new goroutine blocks indefinitely or takes a long time to execute, you could run into a goroutine leak and/or lock contention. is this a concern?

feat: support multiple sync sources #2852 (comment)

closing relistStopChan without checking whether it has already been closed

We should modify the replay code to:

prevent any snowballing from the goroutines by waiting on the child goroutine to be closed, rather than being optimistic that it will close eventually
make the backofff exponential retry-er aware of the kill switch(es) in order to fail fast and not be blocked on the exponential backoff retry-er trying to complete work that we don't want to happen anymore.

acpana self-assigned this

acpana added the SyncSet Related label

acpana mentioned this issue

feat: enhance replay #2984

Merged

acpana closed this as completed in #2984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment