Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add retry limit when fetching/listing expectations in ready tracker #3460

Open
David-Jaeyoon-Lee opened this issue Jul 24, 2024 · 3 comments
Labels
enhancement New feature or request stale

Comments

@David-Jaeyoon-Lee
Copy link
Contributor

Describe the solution you'd like
In order for #3308 to take affect, we need to add support for users to set a retry limit when fetching expectations. This involves creating a retryPredicate that sets the number of retries based on a user defined limit/count. Currently since the retryPredicate always retries, the crashOnFailureFetchingExpectations is moot and hidden (replaced with a constant false value).

Anything else you would like to add:
In addition to adding support for retry limit, once this is implemented, we need to expose the crashOnFailureFetchingExpectations flag back to the user (delete constant false value and uncomment crashOnFailureFetchingExpectations flag) as well as change any logic that uses that flag as a constant (likely need to dereference the variable)

@ritazh
Copy link
Member

ritazh commented Jul 24, 2024

xref: #3453 (comment)

Copy link

stale bot commented Sep 29, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 29, 2024
@ritazh ritazh removed the stale label Sep 30, 2024
Copy link

stale bot commented Nov 30, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants