Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphincs implementation version dubious #1475

Closed
baentsch opened this issue May 19, 2023 · 1 comment · Fixed by #1477
Closed

Sphincs implementation version dubious #1475

baentsch opened this issue May 19, 2023 · 1 comment · Fixed by #1477
Milestone

Comments

@baentsch
Copy link
Member

While implementing open-quantum-safe/oqs-provider#157 it became obvious (due to no difference in version IDs) that #1420 did not update the version name/ID for the new code version. This is somewhat confusing when listing old and new OIDs: See https://github.com/open-quantum-safe/oqs-provider/blob/mb-algdocs/oqs-template/oqs-sig-info.md : All Sphincs+ algorithms are listed under the same moniker/version string.

As the Sphincs algorithm naming got a complete revamp with #1467, it is no real problem, but this issue is to ask whether it is intentional that there is no (different) version name between the previous Sphincs code base and the current one.

@dstebila
Copy link
Member

You're right, I see that the spec-version line in https://github.com/open-quantum-safe/liboqs/pull/1420/files#diff-cfe013791f73d0afd5867c1e07d9d2e33112f0e04dae3d989fdd67a98234a19fR26 was not updated. I've fixed this is #1475, does that address the downstream issue?

@dstebila dstebila added this to the 0.8.0 milestone May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants