Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "weight" with "parameter".rs #193

Merged
merged 7 commits into from
May 22, 2024
Merged

Replace "weight" with "parameter".rs #193

merged 7 commits into from
May 22, 2024

Conversation

Expertium
Copy link
Contributor

No description provided.

@Expertium
Copy link
Contributor Author

Ok, I don't know why the tests are failing

@AlexErrant
Copy link
Member

AlexErrant commented May 21, 2024 •
edited
Loading

In the spirit of "teach a man to fish":

image

(note the red arrow pointing at cargo fmt)

L-M-Sherlock
L-M-Sherlock approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/optimal_retention.rs Outdated Show resolved Hide resolved
@L-M-Sherlock L-M-Sherlock merged commit a2d9ea0 into open-spaced-repetition:main May 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-M-Sherlock L-M-Sherlock L-M-Sherlock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Expertium @AlexErrant @L-M-Sherlock