Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retry policy: parse datetime value for Retry-After header? #119

Closed
srikanthccv opened this issue Jul 31, 2022 · 3 comments · Fixed by #131
Closed

retry policy: parse datetime value for Retry-After header? #119

srikanthccv opened this issue Jul 31, 2022 · 3 comments · Fixed by #131
Assignees
@nemoshlag

Comments

@srikanthccv
Copy link
Member

I started working on writing tests as part of #99. I noticed that the retry header only works with delay seconds. The header value can either be seconds or datatime. Should the datetime case be accounted for or assume the server always sends the seconds?
@tigrannajaryan
Copy link
Member

I think yes, we should allow datetime since HTTP spec allows that.

@nemoshlag
Copy link
Member

Hi 👋 would like to help with this one if needed

@tigrannajaryan
Copy link
Member

@nemoshlag sounds great, I assigned this issue to you.

@nemoshlag nemoshlag mentioned this issue Sep 19, 2022
Merged
tigrannajaryan pushed a commit that referenced this issue Sep 26, 2022
@nemoshlag
Add client-side support for datetime value of Retry-After header (#131)
491ce60 
According to specifications, Retry-After header should be either seconds-delay or HTTP-date
https://datatracker.ietf.org/doc/html/rfc7231#section-7.1.3

Resolves #119
@nemoshlag nemoshlag mentioned this issue Oct 19, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nemoshlag nemoshlag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add client-side support for datetime value of Retry-After header nemoshlag/opamp-go
3 participants
@tigrannajaryan @nemoshlag @srikanthccv