From 3f0ba14144a13f03e5d6a3466bc67661851fea0b Mon Sep 17 00:00:00 2001 From: sakulali Date: Tue, 5 Sep 2023 21:46:35 +0800 Subject: [PATCH] [exporter/jaeger] do not export method --- .chloggen/jaeger-checkapi.yaml | 27 +++++++++++++++++++++++++ cmd/checkapi/allowlist.txt | 1 - exporter/jaegerexporter/metrics.go | 4 ++-- exporter/jaegerexporter/metrics_test.go | 2 +- 4 files changed, 30 insertions(+), 4 deletions(-) create mode 100644 .chloggen/jaeger-checkapi.yaml diff --git a/.chloggen/jaeger-checkapi.yaml b/.chloggen/jaeger-checkapi.yaml new file mode 100644 index 000000000000..a98d4331d053 --- /dev/null +++ b/.chloggen/jaeger-checkapi.yaml @@ -0,0 +1,27 @@ +# Use this changelog template to create an entry for release notes. + +# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' +change_type: breaking + +# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) +component: jaegerexporter + +# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). +note: Do not export the function `MetricViews` + +# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. +issues: [26304] + +# (Optional) One or more lines of additional information to render under the primary note. +# These lines will be padded with 2 spaces and then inserted directly into the document. +# Use pipe (|) for multiline entries. +subtext: + +# If your change doesn't affect end users or the exported elements of any package, +# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. +# Optional: The change log or logs in which this entry should be included. +# e.g. '[user]' or '[user, api]' +# Include 'user' if the change is relevant to end users. +# Include 'api' if there is a change to a library API. +# Default: '[user]' +change_logs: [api] diff --git a/cmd/checkapi/allowlist.txt b/cmd/checkapi/allowlist.txt index 5bdd40d99f0a..148bf2f94bc2 100644 --- a/cmd/checkapi/allowlist.txt +++ b/cmd/checkapi/allowlist.txt @@ -7,7 +7,6 @@ exporter/coralogixexporter exporter/dynatraceexporter exporter/elasticsearchexporter exporter/f5cloudexporter -exporter/jaegerexporter exporter/kafkaexporter exporter/loadbalancingexporter exporter/logzioexporter diff --git a/exporter/jaegerexporter/metrics.go b/exporter/jaegerexporter/metrics.go index 63d202175d43..ba7e08752d72 100644 --- a/exporter/jaegerexporter/metrics.go +++ b/exporter/jaegerexporter/metrics.go @@ -22,7 +22,7 @@ var ( } ) -// MetricViews return the metrics views according to given telemetry level. -func MetricViews() []*view.View { +// metricViews return the metrics views according to given telemetry level. +func metricViews() []*view.View { return []*view.View{vLastConnectionState} } diff --git a/exporter/jaegerexporter/metrics_test.go b/exporter/jaegerexporter/metrics_test.go index a1984f22a09c..ac75428f60b8 100644 --- a/exporter/jaegerexporter/metrics_test.go +++ b/exporter/jaegerexporter/metrics_test.go @@ -14,7 +14,7 @@ func TestProcessorMetrics(t *testing.T) { "jaegerexporter_conn_state", } - views := MetricViews() + views := metricViews() for i, viewName := range expectedViewNames { assert.Equal(t, viewName, views[i].Name) }