Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create opamp extension #16462

Closed
5 tasks done
Tracked by #24327
tigrannajaryan opened this issue Nov 22, 2022 · 12 comments
Closed
5 tasks done
Tracked by #24327

Create opamp extension #16462

tigrannajaryan opened this issue Nov 22, 2022 · 12 comments
Labels
Accepted Component New component has been sponsored never stale Issues marked with this label will be never staled and automatically removed

Comments

@tigrannajaryan tigrannajaryan transferred this issue from open-telemetry/opentelemetry-collector Nov 23, 2022
@tigrannajaryan tigrannajaryan added the Sponsor Needed New component seeking sponsor label Nov 23, 2022
@tigrannajaryan
Copy link
Member Author

@open-telemetry/collector-contrib-approvers is anyone interested in being the sponsor for this component?

I believe @portertech is interested in implementing it (provided we agree on the design) and I am happy to be a co-owner of the extension and will also review the PRs.

@evan-bradley
Copy link
Contributor

I'll sponsor this.

@evan-bradley evan-bradley added Accepted Component New component has been sponsored and removed Sponsor Needed New component seeking sponsor labels Nov 23, 2022
@dmitryax
Copy link
Member

I can help with reviewing PRs. @portertech feel free to ping me as well

@portertech
Copy link
Contributor

@tigrannajaryan To confirm, the extension will now live in contrib and not in the collector itself? I'll move my WIP if that's the case 👍

@tigrannajaryan
Copy link
Member Author

@tigrannajaryan To confirm, the extension will now live in contrib and not in the collector itself? I'll move my WIP if that's the case 👍

contrib is probably a better place, @open-telemetry/collector-maintainers WDYT?

@codeboten
Copy link
Contributor

i'd assume that in the future this would become a core component, but for now i think it's ok for it to live in contrib. there are other components I imagine will likely move from contrib to core in the future (jaeger/zipkin/prometheus receivers/exporters)

portertech added a commit to sensu/opentelemetry-collector-contrib that referenced this issue Dec 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Apr 10, 2023
@mx-psi mx-psi removed the Stale label Apr 10, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@evan-bradley
Copy link
Contributor

The extension is now at alpha stability and is in the contrib distro, so I think we can say it is in a good state.

@MSA0208
Copy link

MSA0208 commented May 7, 2024

Hi have tried the same steps given by you @brightzheng100 ,
but getting the below error, i tried starting the server from /root/OTEL98/opamp-go-main/internal/examples/server and it started and when i tried the extension from my collector getting below error
extensions:
opamp:
server:
ws:
endpoint: wss://127.0.0.1:4321/v1/opamp
tls:
insecure_skip_verify: false # Set to true if you're using self-signed certificates
ca_file: "/root/certs/sac-hvm03662.swinfra.net.pem"

error [email protected]/logger.go:26 Connection failed (tls: first record does not look like a TLS handshake), will retry. {"kind": "extension", "name": "opamp", "client": "ws"}

The Other way i tried was , started the opampsupervisor from /root/OTEL98/opentelemetry-collector-contrib-main/cmd/opampsupervisor using the command ./opampsupervisor --config supervisor.yaml and my yaml is below
OpAMP backend server settings.
server:
endpoint: wss://127.0.0.1:4320/v1/opamp
tls:
insecure_skip_verify: true

capabilities:
accepts_remote_config: true # false if unspecified

reports_effective_config: true # true if unspecified

accepts_packages: true # false if unspecified

reports_own_metrics: # true if unspecified

reports_own_logs: # true if unspecified

accepts_other_connection_settings: true # false if unspecified

accepts_restart_command: true # true if unspecified

reports_health: true # true if unspecified

storage:
agent:
executable: /root/OTEL98/opentelemetry-collector-contrib-main/cmd/otelcontribcol/OutputBinaries/NGxConnector

args: --config /root/OTEL98/opentelemetry-collector-contrib-main/cmd/otelcontribcol/config.yaml

env:

run_as: root
config_file: /root/OTEL98/opentelemetry-collector-contrib-main/cmd/otelcontribcol/config.yaml
access_dirs:
read:
allow: [/var/log]
deny: [/var/log/secret_logs]
write:
allow: [/var/otelcol]
am getting the error below,
[root@sac-hvm03662 opampsupervisor]# ./opampsupervisor --config supervisor.yaml
2024-05-07T10:40:22.536-0700 DEBUG commander/commander.go:74 Starting agent {"agent": "/root/OTEL98/opentelemetry-collector-contrib-main/cmd/otelcontribcol/OutputBinaries/NGxConnector"}
2024-05-07T10:40:22.537-0700 DEBUG commander/commander.go:93 Agent process started {"pid": 63200}
2024-05-07T10:40:25.540-0700 ERROR opampsupervisor/main.go:31 Failed to initialize supervisor {"error": "could not get bootstrap info from the Collector: collector's OpAMP client never connected to the Supervisor"}
main.main
/root/OTEL98/opentelemetry-collector-contrib-main/cmd/opampsupervisor/main.go:31
runtime.main
/usr/local/go/src/runtime/proc.go:271

please help me out to solve these issues

@mx-psi
Copy link
Member

mx-psi commented May 8, 2024

@MSA0208 please file a separate issue for this, thanks! This issue has been completed and is about creating the extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Component New component has been sponsored never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Development

No branches or pull requests

8 participants